Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24707 )
Change subject: IMPALA-15270: Implement Geospatial ST_Buffer Function Using Boost ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/24707/6/be/src/exprs/geo/geometry-wrapper-wkb.cc File be/src/exprs/geo/geometry-wrapper-wkb.cc: http://gerrit.cloudera.org:8080/#/c/24707/6/be/src/exprs/geo/geometry-wrapper-wkb.cc@756 PS6, Line 756: if (!use_spheroid->is_null && use_spheroid->val) { > The NULL results in PS7 read right, and the new query tests cover them. PS9 doesn't add the is_null check, and the new ParseBufferStyleNullStyleArg now walks that path directly - ptr = nullptr, len = 0 straight into std::string, on every backend test run rather than only from SQL. One line at the top of ParseBufferStyle would cover it and let the test pin the guard instead. Your call whether it belongs in this patch. -- To view, visit http://gerrit.cloudera.org:8080/24707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6faeb533eb464d32629fa402179dc19c25bd78f2 Gerrit-Change-Number: 24707 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 13:28:07 +0000 Gerrit-HasComments: Yes
