Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24707 )
Change subject: IMPALA-15270: Implement Geospatial ST_Buffer Function Using Boost ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24707/7/testdata/workloads/functional-query/queries/QueryTest/geospatial-wkb-serialization.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-wkb-serialization.test: http://gerrit.cloudera.org:8080/#/c/24707/7/testdata/workloads/functional-query/queries/QueryTest/geospatial-wkb-serialization.test@179 PS7, Line 179: select ST_AsText(ST_Buffer(ST_GeomFromText('point (0 0)'), 1, false, 'quad_segs=4 quad_segs=64')); > Since this change depends on https://gerrit.cloudera.org/c/24534 (which set You're right, and I was checking the wrong tree: on master start-impala-cluster.py passes --geospatial_library=HIVE_ESRI and the backend flag defaults to NONE, but with 24534 in the chain the script stops passing the flag and DEFINE_string(geospatial_library, ...) defaults to WKB, so the default minicluster does carry the 3- and 4-arg overloads. Withdrawing the point. And agreed on the assertion - counting the points is what the quad_segs case is really about. -- To view, visit http://gerrit.cloudera.org:8080/24707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6faeb533eb464d32629fa402179dc19c25bd78f2 Gerrit-Change-Number: 24707 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 17:21:23 +0000 Gerrit-HasComments: Yes
