Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24693 )
Change subject: IMPALA-15236: Expose HBO match provenance ...................................................................... Patch Set 8: PS8 goes the explain_level route. Out with the option go its thrift and backend plumbing, Planner.profileExplainDiffers(), Planner.getProfileExplainString() and the second render in Frontend. The details line shows at EXTENDED and above and carries the ratio. Frontend.java and Planner.java are no longer in the patch at all - it is seven files now. Checked on a cluster rather than by reading: TestHBO 20/20 including test_matching_provenance, HistoricalStatsTest 8/8, and by hand - the line in the profile of an ordinary query with nothing set, absent from EXPLAIN at the default level, present at explain_level=2. I also broke it twice on purpose to see the test catch it: gating at STANDARD fails the assertion that the default EXPLAIN carries no details line, and dropping the ratio fails the profile match. Full precommit is running. One thing this patch does not answer, worth naming rather than leaving implied: provenance says the estimate moved, not whether the plan moved. isInvertedJoinCheaper() weighs the two children by cardinality, average row size and node count, so an HBO correction on the build side can flip its verdict - and since the join count and the broadcast/partitioned mix stay the same, a plan comparison by operator counts calls that "no change". Filed as IMPALA-15312 instead of growing this change. -- To view, visit http://gerrit.cloudera.org:8080/24693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2deaaf78a2a41353454ba634a247d8c69825bf Gerrit-Change-Number: 24693 Gerrit-PatchSet: 8 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2026 09:51:21 +0000 Gerrit-HasComments: No
