Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24693 )
Change subject: IMPALA-15236: Expose HBO match provenance ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/24693/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24693/9//COMMIT_MSG@47 PS9, Line 47: that one alone, with "expected:<0[.]05> but was:<0[,]05>" nit: we usually don't mention the difference with previous patch sets. In the git history, people read this and would think it's talking about comparison with previous commits. http://gerrit.cloudera.org:8080/#/c/24693/4/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24693/4/fe/src/main/java/org/apache/impala/planner/PlanNode.java@490 PS4, Line 490: if (hboMatch_ != null > One thing did change there in PS9. The ratio is formatted under Locale.ROOT Nice catch! http://gerrit.cloudera.org:8080/#/c/24693/9/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24693/9/fe/src/main/java/org/apache/impala/planner/PlanNode.java@582 PS9, Line 582: Locale.ROOT, "%.2f", (double) cardinality / cardinalityBeforeHbo); This is a general method that other codes can reuse. Can we move this formatHboRatio method into PrintUtils and use a general name like printTwoDecimalsRatio? -- To view, visit http://gerrit.cloudera.org:8080/24693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2deaaf78a2a41353454ba634a247d8c69825bf Gerrit-Change-Number: 24693 Gerrit-PatchSet: 9 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 14:21:23 +0000 Gerrit-HasComments: Yes
