Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24693 )
Change subject: IMPALA-15236: Expose HBO match provenance ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24693/4/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24693/4/fe/src/main/java/org/apache/impala/planner/PlanNode.java@490 PS4, Line 490: .append(PrintUtils.printEstCardinality(cardinalityBeforeHbo_)) > Two decimals looks good to me. Thanks! One thing did change there in PS9. The ratio is formatted under Locale.ROOT now rather than through DecimalFormat's default, so a coordinator whose JVM default is something like de_DE writes 0.05 and not 0,05 - it is the one field on that line meant to be read by a tool. The cardinalities beside it still go through PrintUtils and follow the default locale, like every other estimate in a plan. HboKeyStringTest::testHboRatioIsLocaleIndependent pins it; putting the DecimalFormat back fails that test alone. -- To view, visit http://gerrit.cloudera.org:8080/24693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2deaaf78a2a41353454ba634a247d8c69825bf Gerrit-Change-Number: 24693 Gerrit-PatchSet: 4 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 09:13:25 +0000 Gerrit-HasComments: Yes
