Aleksandr Efimov has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24718 )

Change subject: IMPALA-15278: Fix incorrect cardinality with OFFSET
......................................................................


Patch Set 4:

Ran the two files after all, off a PlannerTestBase subclass - PlannerTest 
itself needs HBase in its @BeforeClass and my environment has none. 
card-limit-offset passes with VALIDATE_CARDINALITY, and union.test:3885 goes 8 
-> 1, the move I described above; reverting the patch puts it back to 8. 
tpcds_cpu_cost/ddl.test is not covered there - no TPC-DS catalog - so the 
ExchangeNode note stays a read of the code.


-- 
To view, visit http://gerrit.cloudera.org:8080/24718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b628beabc5c7ec6c4fdda9dff6aaf7a4acae538
Gerrit-Change-Number: 24718
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 01 Sep 2026 06:44:15 +0000
Gerrit-HasComments: No

Reply via email to