Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24718 )
Change subject: IMPALA-15278: Fix incorrect cardinality with OFFSET ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24718/4/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java File fe/src/main/java/org/apache/impala/planner/ExchangeNode.java: http://gerrit.cloudera.org:8080/#/c/24718/4/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java@155 PS4, Line 155: cardinality_ = capCardinalityAtLimit(children_.get(0).getCardinality(), offset_); > The merging exchange mem-estimate moves with this: in tpcds_cpu_cost/ddl.te Nice finding! I think we should use the input cardinality in those methods. Since it's another existing bug, instead of adding a TODO, could you please file a JIRA to track it? -- To view, visit http://gerrit.cloudera.org:8080/24718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b628beabc5c7ec6c4fdda9dff6aaf7a4acae538 Gerrit-Change-Number: 24718 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 01 Sep 2026 10:29:11 +0000 Gerrit-HasComments: Yes
