Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24786 )
Change subject: IMPALA-15257: Add TCP keepalive support for internal Thrift traffic ...................................................................... Patch Set 1: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py File tests/custom_cluster/test_internal_keepalive.py: http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@38 PS1, Line 38: class TestInternalKeepalive(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@49 PS1, Line 49: l flake8: E741 ambiguous variable name 'l' http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@52 PS1, Line 52: " flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@61 PS1, Line 61: l flake8: E741 ambiguous variable name 'l' http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@78 PS1, Line 78: r flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@82 PS1, Line 82: flake8: E501 line too long (114 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@84 PS1, Line 84: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@85 PS1, Line 85: t flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@90 PS1, Line 90: " flake8: E501 line too long (115 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@92 PS1, Line 92: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/24786/1/tests/custom_cluster/test_internal_keepalive.py@93 PS1, Line 93: flake8: E501 line too long (110 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/24786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9fec7a02b2c5ef92e8b68de9e3993bcee7bc898 Gerrit-Change-Number: 24786 Gerrit-PatchSet: 1 Gerrit-Owner: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 15:40:38 +0000 Gerrit-HasComments: Yes
