Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24786 )

Change subject: IMPALA-15257: Add TCP keepalive support for internal Thrift 
traffic
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24786/2/tests/custom_cluster/test_internal_keepalive.py
File tests/custom_cluster/test_internal_keepalive.py:

http://gerrit.cloudera.org:8080/#/c/24786/2/tests/custom_cluster/test_internal_keepalive.py@87
PS2, Line 87: v
flake8: U100 Unused argument 'vector'


http://gerrit.cloudera.org:8080/#/c/24786/2/tests/custom_cluster/test_internal_keepalive.py@97
PS2, Line 97: v
flake8: U100 Unused argument 'vector'



--
To view, visit http://gerrit.cloudera.org:8080/24786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fec7a02b2c5ef92e8b68de9e3993bcee7bc898
Gerrit-Change-Number: 24786
Gerrit-PatchSet: 2
Gerrit-Owner: Jiyoung Yoo <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 03 Sep 2026 17:14:13 +0000
Gerrit-HasComments: Yes

Reply via email to