Hello Yida Wu, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24786
to look at the new patch set (#5).
Change subject: IMPALA-15257: Add option to use keepalive for internal cluster
Thrift connections
......................................................................
IMPALA-15257: Add option to use keepalive for internal cluster Thrift
connections
External Thrift connections and internal KRPC traffic support TCP keepalive,
but internal Thrift connections previously had no keepalive tuning.
This patch adds TCP keepalive tuning for both internal Thrift clients
and servers using three new flags (matching default KRPC settings):
- internal_keepalive_probe_period_s (default: 60)
- internal_keepalive_retry_period_s (default: 3)
- internal_keepalive_retry_count (default: 10)
Implementation details:
- Enabled keepalive on internal ThriftServerBuilder instances
(CatalogService, StatestoreSubscriber, StatestoreService,
StatestoreHaService).
- Applied keepalive socket options in ThriftClientImpl::Open().
- Failures are logged as warnings and do not break connection establishment.
Testing:
- Added tests/custom_cluster/test_internal_keepalive.py.
Assisted-by: Claude (Opus)
Change-Id: If9fec7a02b2c5ef92e8b68de9e3993bcee7bc898
---
M be/src/catalog/catalogd-main.cc
M be/src/rpc/thrift-client.cc
M be/src/rpc/thrift-util.cc
M be/src/rpc/thrift-util.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_client_keepalive.py
A tests/custom_cluster/test_internal_keepalive.py
9 files changed, 189 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/24786/5
--
To view, visit http://gerrit.cloudera.org:8080/24786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9fec7a02b2c5ef92e8b68de9e3993bcee7bc898
Gerrit-Change-Number: 24786
Gerrit-PatchSet: 5
Gerrit-Owner: Jiyoung Yoo <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
