Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: IMPALA-15161: Add GEOMETRY type + make WKB_EXPERIMENTAL default ...................................................................... Patch Set 20: (9 comments) http://gerrit.cloudera.org:8080/#/c/24534/13/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/24534/13/be/src/exprs/expr-test.cc@8722 PS13, Line 8722: NULL is becau > not needed Done http://gerrit.cloudera.org:8080/#/c/24534/13/be/src/exprs/expr-test.cc@8723 PS13, Line 8723: urrently Ja > not always true Done http://gerrit.cloudera.org:8080/#/c/24534/13/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/24534/13/bin/start-impala-cluster.py@165 PS13, Line 165: > Let's change just L163, this script is not a budled artifact, it's only a h Done http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@64 PS13, Line 64: /** > This whole class is now ravaged by conditions and branches based on the imp I agree that this is becoming a mess, but I would prefer to keep it for now to avoid needing to rewrite https://gerrit.cloudera.org/#/c/24540/12/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@72 PS13, Line 72: GeometryUtils.setFormat(lib.equals(TGeospatialLibrary.WKB_EXPERIMENTAL) > BinaryToBinaryHiveLegacyFunctionExtractor is a separate class, it should al Done http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@1709 PS13, Line 1709: // first_value/last_value/lag/lead just copy a value through (no comparison), so > It enables an unrelated feature, it could be done separately These are very simple, they don't need to know anything about the type, so generally I think that each type should suppport them. It would be nicer to have some tests framework that simply tests such boilerplate functions for all types. http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@3358 PS13, Line 3358: > nit: looks odd agree, DataSourceTable.isSupportedPrimitiveType(type) should filter these http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/24534/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2495 PS13, Line 2495: : // GEO > not needed, AI slop simplified it http://gerrit.cloudera.org:8080/#/c/24534/13/tests/custom_cluster/test_geospatial_library.py File tests/custom_cluster/test_geospatial_library.py: http://gerrit.cloudera.org:8080/#/c/24534/13/tests/custom_cluster/test_geospatial_library.py@33 PS13, Line 33: (self): > not needed Done -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 20 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 18:11:33 +0000 Gerrit-HasComments: Yes
