Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: IMPALA-15161: Add GEOMETRY type + make WKB_EXPERIMENTAL default ...................................................................... Patch Set 21: (3 comments) http://gerrit.cloudera.org:8080/#/c/24534/17/tests/custom_cluster/test_geospatial_library.py File tests/custom_cluster/test_geospatial_library.py: http://gerrit.cloudera.org:8080/#/c/24534/17/tests/custom_cluster/test_geospatial_library.py@91 PS17, Line 91: self.run_test_case('QueryTest/geospatial-wkb-serialization', vector) > This one and test_esri_geospatial_functions_extra above run the same file, thx, removed it http://gerrit.cloudera.org:8080/#/c/24534/17/tests/custom_cluster/test_geospatial_library.py@94 PS17, Line 94: self.run_test_case('QueryTest/geospatial-relations-table', vector) > Running the serialization and relations files in both modes makes sense to renamed and cleaned up comment execute_serially was redundant in this case http://gerrit.cloudera.org:8080/#/c/24534/17/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/24534/17/tests/query_test/test_geospatial_functions.py@33 PS17, Line 33: v.get_value('table_format').file_format == 'text') > The comment right above still says "Tests do not use tables at the moment, Done -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 21 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 18:33:12 +0000 Gerrit-HasComments: Yes
