Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: IMPALA-15161: Add GEOMETRY type + make WKB_EXPERIMENTAL default ...................................................................... Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/24534/21/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24534/21/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@a3356 PS21, Line 3356: > Was this delete intentional? Yes, but it turned out to break the tests, as uuid and geometry return different error messages. Updated the test to expect the right error message per type. Also created IMPALA-15350 to clean up table+column type checks. http://gerrit.cloudera.org:8080/#/c/24534/21/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4257 PS21, Line 4257: @Test > Should there also be tests for alter table add column of type geometry? Thanks, added tests and actually caught bugs! The analyzer allowed it, and the the column was added as BINARY. Added checks to the statement and created IMPALA-15350 to clean up table+column type checks. -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 23 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 14 Sep 2026 17:36:19 +0000 Gerrit-HasComments: Yes
