Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24786 )
Change subject: IMPALA-15257: Add option to use keepalive for internal cluster Thrift connections ...................................................................... Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24786/6/be/src/rpc/thrift-util.h File be/src/rpc/thrift-util.h: http://gerrit.cloudera.org:8080/#/c/24786/6/be/src/rpc/thrift-util.h@235 PS6, Line 235: cketType::createSocket(socket); : if (keepalive_enabled_) { > Should the client and server use the same keepalive values? Do you have a specific reason that would be an issue? I can't think of one at the moment. -- To view, visit http://gerrit.cloudera.org:8080/24786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9fec7a02b2c5ef92e8b68de9e3993bcee7bc898 Gerrit-Change-Number: 24786 Gerrit-PatchSet: 7 Gerrit-Owner: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 16:49:47 +0000 Gerrit-HasComments: Yes
