Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24874 )
Change subject: IMPALA-15363: Update toolchain builders to Java 17 ...................................................................... Patch Set 5: (2 comments) Looks good in general; I've added a suggestion to pick up Rocky Linux images from the project's own Docker Hub space instead of the "official" images curated by Docker Hub (details in the comments). There is also a latent failure waiting in the SLES 16 build, which I found when working on https://gerrit.cloudera.org/c/23405/ : @joemcdonnell found out that SLES 16 changed their 'alternatives' implementation to /usr/bin/alts, which interferes with the Kudu build. Unfortunately this shows up only during the first toolchain build after the SLES 16 build container is regenerated. Joe proposed the following patch for the Kudu build in private communication: ===========8<========== >From c674a1e196290a24914ea986ea0f5423e8fa2cb5 Mon Sep 17 00:00:00 2001 From: Joe McDonnell <[email protected]> Date: Thu, 23 Jul 2026 17:41:23 -0700 Subject: [PATCH] Fix up Kudu build's JAVA_HOME logic to handle SLES16's /usr/bin/alts Change-Id: I5de832ca8178b29806a1fbf6ad273ee94dd6b24c --- source/kudu/build.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/source/kudu/build.sh b/source/kudu/build.sh index 1e3913b..f2cec20 100755 --- a/source/kudu/build.sh +++ b/source/kudu/build.sh @@ -109,6 +109,12 @@ function build { # Follow symlinks to get the real path of javac # Ex: /usr/lib/jvm/java-17-temurin-jdk/bin/javac JAVAC_REAL_LOCATION=$(realpath $JAVAC_SYMLINK) + # SLES uses an alternatives implementation that passes through /usr/bin/alts, + # which determines which executable to call. If we're on that system, ask + # /usr/bin/alts to tell us the location. + if [[ "${JAVAC_REAL_LOCATION}" == "/usr/bin/alts" ]]; then + JAVAC_REAL_LOCATION=$(/usr/bin/alts -t javac) + fi # Trim off /bin/javac export JAVA_HOME=$(echo $JAVAC_REAL_LOCATION | sed 's#/bin/javac##') fi -- 2.43.0 ==========8<========= http://gerrit.cloudera.org:8080/#/c/24874/5/docker/redhat8.df File docker/redhat8.df: http://gerrit.cloudera.org:8080/#/c/24874/5/docker/redhat8.df@1 PS5, Line 1: rockylinux:8.9 : For Rocky images I'd suggest using the Rocky project's own registry, changing this to rockylinux/rockylinux:8.10. That would also let us pick up 8.10, the latest minor release on the 8.x line Docker Hub says this on their own Rocky page: ------------ IMPORTANT NOTE The Docker team curates the Official Images program, and there are currently some technical constraints preventing Rocky Linux from publishing updates here. For the most up-to-date container images, please refer to the Rocky Linux Docker Hub repository for now. ------------ [https://hub.docker.com/_/rockylinux#important-note] http://gerrit.cloudera.org:8080/#/c/24874/5/docker/redhat9.df File docker/redhat9.df: http://gerrit.cloudera.org:8080/#/c/24874/5/docker/redhat9.df@1 PS5, Line 1: FROM rockylinux:9.3 I'd suggest the rockylinux/rockylinux registry here as well. Additionally, even-numbered minor releases are considered to be more stable by Red Hat, so I'd expect the same for Rocky, so I'd also suggest bumping this to 9.4, if you don't want to grab the most recent one. -- To view, visit http://gerrit.cloudera.org:8080/24874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8b52284e4043284597e8d0867c730a9485fa1ca Gerrit-Change-Number: 24874 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 12:17:56 +0000 Gerrit-HasComments: Yes
