Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24874 )
Change subject: IMPALA-15363: Update toolchain builders to Java 17 ...................................................................... Patch Set 5: > Patch Set 5: > > (2 comments) > > Looks good in general; I've added a suggestion to pick up Rocky Linux images > from the project's own Docker Hub space instead of the "official" images > curated by Docker Hub (details in the comments). > > There is also a latent failure waiting in the SLES 16 build, which I found > when working on https://gerrit.cloudera.org/c/23405/ : > @joemcdonnell found out that SLES 16 changed their 'alternatives' > implementation to /usr/bin/alts, which interferes with the Kudu build. > Unfortunately this shows up only during the first toolchain build after the > SLES 16 build container is regenerated. > Joe proposed the following patch for the Kudu build in private communication: > ===========8<========== > From c674a1e196290a24914ea986ea0f5423e8fa2cb5 Mon Sep 17 00:00:00 2001 > From: Joe McDonnell <[email protected]> > Date: Thu, 23 Jul 2026 17:41:23 -0700 > Subject: [PATCH] Fix up Kudu build's JAVA_HOME logic to handle SLES16's > /usr/bin/alts > > Change-Id: I5de832ca8178b29806a1fbf6ad273ee94dd6b24c > --- > source/kudu/build.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/source/kudu/build.sh b/source/kudu/build.sh > index 1e3913b..f2cec20 100755 > --- a/source/kudu/build.sh > +++ b/source/kudu/build.sh > @@ -109,6 +109,12 @@ function build { > # Follow symlinks to get the real path of javac > # Ex: /usr/lib/jvm/java-17-temurin-jdk/bin/javac > JAVAC_REAL_LOCATION=$(realpath $JAVAC_SYMLINK) > + # SLES uses an alternatives implementation that passes through > /usr/bin/alts, > + # which determines which executable to call. If we're on that system, ask > + # /usr/bin/alts to tell us the location. > + if [[ "${JAVAC_REAL_LOCATION}" == "/usr/bin/alts" ]]; then > + JAVAC_REAL_LOCATION=$(/usr/bin/alts -t javac) > + fi > # Trim off /bin/javac > export JAVA_HOME=$(echo $JAVAC_REAL_LOCATION | sed 's#/bin/javac##') > fi > -- > 2.43.0 > ==========8<========= I ran into the SLES 16 rebuild issue, thanks for digging it up. -- To view, visit http://gerrit.cloudera.org:8080/24874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8b52284e4043284597e8d0867c730a9485fa1ca Gerrit-Change-Number: 24874 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 15:11:46 +0000 Gerrit-HasComments: No
