Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 )
Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10900/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10900/3//COMMIT_MSG@12 PS3, Line 12: Also fixed IMPALA-7286 Please be a bit more talkative about this :) at least add the title of the Jira like "IMPALA-7286 Command "unset" does not work for shell options" http://gerrit.cloudera.org:8080/#/c/10900/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10900/3/shell/impala_shell.py@657 PS3, Line 657: print 'Unsetting shell option %s' % token Please move this to the calling function to be consistent with the other printed messages. -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 3 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Jinchul Kim <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 13 Jul 2018 16:08:05 +0000 Gerrit-HasComments: Yes
