Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 )
Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell ...................................................................... Patch Set 5: (1 comment) Seems good to me, only missed some doc comments. http://gerrit.cloudera.org:8080/#/c/10900/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10900/5/tests/shell/test_shell_interactive.py@91 PS5, Line 91: p = ImpalaShell() nit: please add some doc comments to the tests. -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 5 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Jinchul Kim <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 16 Jul 2018 15:07:20 +0000 Gerrit-HasComments: Yes
