Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 )
Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell ...................................................................... Patch Set 6: (2 comments) LGTM, except one tiny nit. I can give a +2 if the change was confirmed to to be tested on both Python 2.6 and 2.7. http://gerrit.cloudera.org:8080/#/c/10900/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10900/6//COMMIT_MSG@15 PS6, Line 15: Added tests for all new options in test_shell_interactive.py Did you test this change on Python 2.6 as well? If yes, can you update the commit message saying tested on Python 2.6 and Python 2.7? http://gerrit.cloudera.org:8080/#/c/10900/6/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10900/6/tests/shell/test_shell_interactive.py@122 PS6, Line 122: 'r' nit: use "r" to be consistent with the code in this function. -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 6 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Jinchul Kim <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 27 Jul 2018 17:04:31 +0000 Gerrit-HasComments: Yes
