Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails ...................................................................... Patch Set 20: (9 comments) http://gerrit.cloudera.org:8080/#/c/10571/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10571/18//COMMIT_MSG@14 PS18, Line 14: ite fails. : > remove? Done http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@453 PS18, Line 453: // The rewrites should have no user-visible effect. Remember the original result > How about moving the try-catch much closer to the analyze()? Done http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@473 PS18, Line 473: throw e; : } : > Do we still need this? It think it's still quite useful wen TRACE is enabled. http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@479 PS18, Line 479: > May be say "Error analyzing the rewritten query"? Rewrite is already succes Done http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java File fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@72 PS18, Line 72: if (!rewritten && sqlString_ != null) return sqlString_; : > merge? Done http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@76 PS18, Line 76: if (fromClause_.size() > 1 || targetTableRef_.hasExplicitAlias()) { > If rewritten = true and sqlString_ == null, which means toSql(true) is call By uninitialized states, did you mean targetTableRef, fromClause, and wherePredicate? Those are supposedly initialized in the constructor. I believe other statements follow similar patterns. Although I do believe we typically call toSql() after the statement has been analyzed. http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@939 PS18, Line 939: // Return the SQL string before inline-view expression substitution. : if (!rewritten && sqlString_ != null) return sqlString_; : : S > merge Done http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@135 PS18, Line 135: > If rewritten is true..returns the...if the stmt is rewritten..? Done http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@a100 PS18, Line 100: > Isn't the semantics that sqlString_ is populated in analyze(), if so, doesn There was an earlier discussion regarding this: https://gerrit.cloudera.org/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java#117 and Tianyi suggested to remove this. Removing this fixes a different problem in AnalyzeSubqueriesTest.java: https://gerrit.cloudera.org/c/10571/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java#714 -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 20 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 13 Jul 2018 19:09:21 +0000 Gerrit-HasComments: Yes
