Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails ...................................................................... Patch Set 21: Code-Review+1 (6 comments) Carry Bharath's +1 http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@a100 PS18, Line 100: > That makes sense as it is much closer to the user written SQL than before. Done http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java@556 PS20, Line 556: > nit: merge Done http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java File fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java@81 PS20, Line 81: if (!rewritten && sqlString_ != null) return sqlString_; : : S > merge Done http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java: http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java@714 PS20, Line 714: WHERE a.int_col BETWEEN t.tinyint_col AND t.bigint_col) > This makes more sense Done http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@253 PS20, Line 253: > I wasn't aware of this till now :-) I was surprised this too :) http://gerrit.cloudera.org:8080/#/c/10571/20/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@261 PS20, Line 261: : assertToSql(ctx, : "select * from (select * from functional.alltypes where id = (select 1 + 1)) a " + : "union " + : "select * from (select * from functional.alltypes where id = (select 1 + 1)) b", : "SELECT * FROM (SELECT * FROM functional.alltypes WHERE id = (SELECT 1 + 1)) a " + : "UNION " + : "SELECT * FROM (SELECT * FROM functional.alltypes W > can we factor these out into a method? Good idea. Done. -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 21 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 13 Jul 2018 22:42:30 +0000 Gerrit-HasComments: Yes
