Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails ...................................................................... Patch Set 21: Code-Review+2 (2 comments) I'm fine with the patch... thx for working on this. I have two more comment improvement requests so let me know if you have an alternative suggestion. http://gerrit.cloudera.org:8080/#/c/10571/21/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/10571/21/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@136 PS21, Line 136: * rewritten. Otherwise, the original SQL will be returned instead. explicitly state that its the caller's responsibility to know if/when the statement was indeed rewritten. http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@191 PS18, Line 191: , : boolean rewritten > The original behavior is still the same when calling ctasStmt.toSql(), see ok, pls add a comment for the new param and state that its only for testing (that part was not obvious). -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 21 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 01:06:59 +0000 Gerrit-HasComments: Yes
