Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/10992/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10992/3//COMMIT_MSG@9 PS3, Line 9: impad typo: impalad http://gerrit.cloudera.org:8080/#/c/10992/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/10992/3/shell/impala_client.py@233 PS3, Line 233: If not, an exception : will be caught I think the internal workings of the function shouldn't be described in the doc comment. The user of this method only needs to know what will be the result on what condition. http://gerrit.cloudera.org:8080/#/c/10992/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/3/shell/impala_shell.py@614 PS3, Line 614: promt typo: prompt http://gerrit.cloudera.org:8080/#/c/10992/3/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/10992/3/tests/custom_cluster/test_shell_interactive_reconnect.py@85 PS3, Line 85: self._start_impala_cluster(["--kill"]) : self._start_impala_cluster([]) Is this really needed? Before each test a clean new impala cluster is started anyway. Also, if you just want to restart the cluster, you don't need to kill it. You can just call _start_impala_cluster([]) -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 4 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 20 Jul 2018 13:55:53 +0000 Gerrit-HasComments: Yes
