Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@616 PS5, Line 616: return self.default(line) : return func(arg) : > Done As every invocation is used to set self.prompt, the assignment could be moved inside the function. In that case I would prefer "set_prompt" as name. http://gerrit.cloudera.org:8080/#/c/10992/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/6/shell/impala_shell.py@581 PS6, Line 581: if self.imp_client.connected: : # After reconnecting, the prompt name should also be updated. : if self.current_db is None: : self.current_db = self.DEFAULT_DB : self.prompt = self.format_prompt(self.current_db) Are you sure that this is needed? http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py@87 PS6, Line 87: NUM_QUERIES = 'impala-server.num-queries' This could go to an outer scope as both more than one tests use it. http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py@92 PS6, Line 92: ocalhost:21000 This is not needed if you are using the default port. http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py@108 PS6, Line 108: proc.sendline("show databases;") : proc.expect("tpch") Do you want to keep these? I think these were added as a temporary solution to test something. -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 6 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 17:40:38 +0000 Gerrit-HasComments: Yes
