Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_client.py@233 PS5, Line 233: Checks to see if the current Impala connection is still alive. How about this; """Returns True if the current Impala connection is alive and False otherwise.""" http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@616 PS5, Line 616: self.prompt = ImpalaShell.PROMPT_FORMAT.format(host=self.impalad[0], : port=self.impalad[1], : db=current_db) How about moving this to a new set_prompt(db) function? self.prompt is set in 3 different places in this file, only the db part differs. http://gerrit.cloudera.org:8080/#/c/10992/5/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/10992/5/tests/custom_cluster/test_shell_interactive_reconnect.py@91 PS5, Line 91: "[Not connected]" Can we use ImpalaShell.DISCONNECTED_PROMPT here instead of the hard-coded string literal? -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 5 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 23 Jul 2018 14:11:43 +0000 Gerrit-HasComments: Yes
