anujphadke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11020


Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting 
IntVal to DecimalValue
......................................................................

IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to 
DecimalValue

This change adds a check for an overflow which can happen during
converting num_buckets from IntVal to a DecimalValue during width_bucket
evaluation. An overflow can result in hitting a DCHECK if it needs int256
for intermediate evaluations or returns a wrong result otherwise.

Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60
---
M be/src/exprs/expr-test.cc
M be/src/exprs/math-functions-ir.cc
2 files changed, 18 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/11020/1
--
To view, visit http://gerrit.cloudera.org:8080/11020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60
Gerrit-Change-Number: 11020
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke <[email protected]>

Reply via email to