Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11020 )
Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11020/1/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/11020/1/be/src/exprs/math-functions-ir.cc@541 PS1, Line 541: stringstream error_msg; > Nit: we prefer Substitute() over stringstream where possible (although I gu Just to be clear, this one would be nice but is optional since it's consistent with the other code -- To view, visit http://gerrit.cloudera.org:8080/11020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60 Gerrit-Change-Number: 11020 Gerrit-PatchSet: 1 Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 20:37:29 +0000 Gerrit-HasComments: Yes
