anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11020 )
Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11020/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/11020/1/be/src/exprs/expr-test.cc@5382 PS1, Line 5382: // IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue > Can you mention the JIRA number here for context? Done http://gerrit.cloudera.org:8080/#/c/11020/1/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/11020/1/be/src/exprs/math-functions-ir.cc@541 PS1, Line 541: stringstream error_msg; > Just to be clear, this one would be nice but is optional since it's consist Having issues building impala locally to verify. I have fixed the comment. I will send a follow up patch and replace this. -- To view, visit http://gerrit.cloudera.org:8080/11020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60 Gerrit-Change-Number: 11020 Gerrit-PatchSet: 2 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Aug 2018 21:32:25 +0000 Gerrit-HasComments: Yes
