Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11085 )
Change subject: WIP: IMPALA-7317: comment on long lines and whitespace ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py@113 PS1, Line 113: = flake8: E501 line too long (107 > 90 characters) http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py@113 PS1, Line 113: # This is a long line that I will remove before merging =================================================== line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py@114 PS1, Line 114: # This is a line with a tab that I will remove tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py@115 PS1, Line 115: def get_misc_comments(revision): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py@173 PS1, Line 173: flake8: E303 too many blank lines (3) http://gerrit.cloudera.org:8080/#/c/11085/1/bin/jenkins/critique-gerrit-review.py@192 PS1, Line 192: a[k].extend(v) flake8: E305 expected 2 blank lines after class or function definition, found 1 -- To view, visit http://gerrit.cloudera.org:8080/11085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2 Gerrit-Change-Number: 11085 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 00:06:10 +0000 Gerrit-HasComments: Yes
