Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11085 )
Change subject: IMPALA-7317: comment on long lines and whitespace ...................................................................... Patch Set 5: (4 comments) Added a --dryrun mode to disable the postback to gerrit. I was already running it locally to test but relying on the ssh to gerrit failing. http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@124 PS2, Line 124: # This is a long line that I will remove before merging =================================================== : # This is a line with a tab that I will remove : def get_misc_comments(revision): > I think you can compress lines 121-126 by just using Done http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@148 PS2, Line 148: break > Should this be diff_line[2:]? i.e., I think that additions are prefix with They're not in this output mode at least - there are plenty of lines with + and no subsequent space. http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@162 PS2, Line 162: > What's going to be our policy for ignoring these? Do we want to whitelist t I added a whitelist of source file extensions so it will only apply to those. I think we still want to check comments - comments are actually one of the more common places for weird formatting in my experience. http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@167 PS2, Line 167: # Check for trailing whitespace. > nit: s/tables/tabs Removed since makefile isn't in whitelists anyway. -- To view, visit http://gerrit.cloudera.org:8080/11085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2 Gerrit-Change-Number: 11085 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 22:18:04 +0000 Gerrit-HasComments: Yes
