Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11085 )
Change subject: WIP: IMPALA-7317: comment on long lines and whitespace ...................................................................... Patch Set 2: (4 comments) Do we need a mode to run this manually? http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@124 PS2, Line 124: stdout, _ = git_diff_proc.communicate() : if git_diff_proc.returncode != 0: : raise Exception("Git diff exited with code:\n{0}".format(git_diff_proc.returncode)) I think you can compress lines 121-126 by just using stdout = subprocess.check_output(...) http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@148 PS2, Line 148: add_misc_comments_for_line(comments, diff_line[1:], curr_file, curr_line_num) Should this be diff_line[2:]? i.e., I think that additions are prefix with "+ " (2 characters). http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@162 PS2, Line 162: if len(line) > 90: What's going to be our policy for ignoring these? Do we want to whitelist this to source code (py, cc, h, java) and non-comment (i.e., strip off "//") and limit the number of hits overall? git grep -E '.{81}' returns quite a few of results... http://gerrit.cloudera.org:8080/#/c/11085/2/bin/jenkins/critique-gerrit-review.py@167 PS2, Line 167: # Check for tabs (unless it's a Makefile, which requires tables). nit: s/tables/tabs -- To view, visit http://gerrit.cloudera.org:8080/11085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2 Gerrit-Change-Number: 11085 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 20:53:35 +0000 Gerrit-HasComments: Yes
