Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 )
Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell ...................................................................... Patch Set 7: Code-Review+2 > Patch Set 7: > > Some flake8 warnings: > flake8: E201 whitespace after '[' > flake8: E202 whitespace before ']' > > The flake8 warnings don't seem to correspond with the diff. Tim, do you want > to take a look at this? >From the mailing list, it looks like a bug in automatic code review pre-commit >job for flake8. This patch looks good. So, I'm giving it a +2. -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 7 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jinchul Kim <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 17:06:16 +0000 Gerrit-HasComments: No
