Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11085 )
Change subject: IMPALA-7317: comment on long lines and whitespace ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Thanks. Makes sense to me. I think the whitelist/blacklist approach will be handy. http://gerrit.cloudera.org:8080/#/c/11085/5/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/11085/5/bin/jenkins/critique-gerrit-review.py@65 PS5, Line 65: EXCLUDE_FILE_PATTERNS = [ nice -- To view, visit http://gerrit.cloudera.org:8080/11085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2 Gerrit-Change-Number: 11085 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 23:05:27 +0000 Gerrit-HasComments: Yes
