Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 )
Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java File fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java: http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@40 PS1, Line 40: TreeMultiset<Long> > Internally the TreeMultiset actually uses a pair of <element, count> in its It is not super clear to me (looking at the usage of CatalogObjectVersionQueue) whether we need to support duplicate versions. I agree that the default implementation of PriorityQueue allows duplicates but I'm not sure if we were relying on that behavior. http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@67 PS1, Line 67: null Should this be set to INITIAL_CATALOG_VERSION and then getMinimumVersion() just return minVersion_... http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java: http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java@77 PS1, Line 77: doRemove(20); Can you add a few multithreaded addAll(), RemoveAll() since the underlying add() remove() can be interleaved. -- To view, visit http://gerrit.cloudera.org:8080/11109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef Gerrit-Change-Number: 11109 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Aug 2018 21:11:01 +0000 Gerrit-HasComments: Yes
