Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 )
Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11109/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java: http://gerrit.cloudera.org:8080/#/c/11109/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java@60 PS2, Line 60: min I had to look at this twice to see that it made sense to just look at the min since its called for each operation. I was wondering why the entire contents aren't checked. Might be useful to add a comment. -- To view, visit http://gerrit.cloudera.org:8080/11109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef Gerrit-Change-Number: 11109 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 08 Aug 2018 00:44:55 +0000 Gerrit-HasComments: Yes
