Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 )
Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java File fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java: http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@40 PS1, Line 40: it's likely that > sgtm. Added a TODO and will try that out in a follow-on patch. http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@67 PS1, Line 67: l) { > Should this be set to INITIAL_CATALOG_VERSION and then getMinimumVersion() Done -- To view, visit http://gerrit.cloudera.org:8080/11109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef Gerrit-Change-Number: 11109 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 23:06:33 +0000 Gerrit-HasComments: Yes
