Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 )
Change subject: IMPALA-6709: Simplify tests that copy local files to tables ...................................................................... Patch Set 1: (2 comments) Thanks for jumping on this! http://gerrit.cloudera.org:8080/#/c/11127/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11127/1//COMMIT_MSG@17 PS1, Line 17: I only refactored tests that work on Parquet files : since we only have a CREATE TABLE LIKE statement : for this format. A function that expects the create statement as argument could help in other cases - it would not be as comfortable as the Parquet case, but it would still be an improvement in my opinion. The substitution of db and table name could be done inside the function by expecting {DB}.{TBL} or similar placeholders in the input. Feel free to skip this if you want, but please don't resolve the ticket in this case because I plan to do the change in the future. http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py File tests/common/test_parquet.py: http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py@24 PS1, Line 24: create_table_from_file As this only works for Parquet files I would prefer include "parquet" in the name somehow, e.g. create_table_from_parquet. -- To view, visit http://gerrit.cloudera.org:8080/11127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f Gerrit-Change-Number: 11127 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 14:43:49 +0000 Gerrit-HasComments: Yes
