Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 )
Change subject: IMPALA-6709: Simplify tests that copy local files to tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11127/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11127/1/tests/query_test/test_scanners.py@a318 PS1, Line 318: : A note of caution here. There is a distinction between: #1. create table foo (field1 type) stored as parquet; #based on file blah and #2. create table foo like parquet blah; # where blah happens to have a field1 with a certain type #1 specifies the types. #2 tries to infer the types from the parquet file. These can produce different schemas. I'm ok with switching tests over to this, as long as we are testing the same behavior. I'd be interested in whether any schemas are different with this change. -- To view, visit http://gerrit.cloudera.org:8080/11127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f Gerrit-Change-Number: 11127 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 17:31:28 +0000 Gerrit-HasComments: Yes
