Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 )
Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/11124/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11124/3//COMMIT_MSG@12 PS3, Line 12: accpet nit: typo http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/rpc/impala-service-pool.cc@266 PS3, Line 266: value->AddMember("queue_size", Value(service_queue_.estimated_queue_length()).Move(), hmm, this seems a bit odd. For primitives, we can't just use the original syntax? https://github.com/Tencent/rapidjson/blob/0f96b5605a5279bdc1831500de45e89ee516380b/test/unittest/valuetest.cpp#L1231 seems to be OK with it, and I tried it locally and it seemed OK. http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/util/thread.cc File be/src/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/util/thread.cc@259 PS3, Line 259: val.AddMember("category", rapidjson::StringRef(category->first.c_str()), this one seems racy to do without copying since you're taking a reference to a string which is protected by a lock, but that reference outlives the lock scope. For most of these StringRefs I think we should take defensive copies by default and only try to be zero-copy on serialization when we really believe it's a hot path. http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/util/thread.cc@275 PS3, Line 275: val.AddMember("name", rapidjson::StringRef(thread.second.name().c_str()), same -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 18:13:17 +0000 Gerrit-HasComments: Yes
