Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 )
Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/util/thread.cc File be/src/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/11124/3/be/src/util/thread.cc@259 PS3, Line 259: val.AddMember("category", rapidjson::StringRef(category->first.c_str()), > this one seems racy to do without copying since you're taking a reference t Looks like it was probably a pre-existing bug - nice find. Agree with being defensive - a lot of existing code looks like a bit of an anti-pattern -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 18:23:49 +0000 Gerrit-HasComments: Yes
