Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 )
Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11124/5/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/11124/5/be/src/service/impala-http-handler.cc@227 PS5, Line 227: rapidjson::StringRef(args.find("query_id")->second.c_str()), this one seems like it would be safer to copy, too. Currently I guess the lifetime of the args is longer than the lifetime of the response JSON, but seems like a simple refactor of the calling code might break that. http://gerrit.cloudera.org:8080/#/c/11124/5/be/src/service/impala-http-handler.cc@285 PS5, Line 285: rapidjson::StringRef(args.find("query_id")->second.c_str()), same one here -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 16:56:37 +0000 Gerrit-HasComments: Yes
