Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 )
Change subject: IMPALA-7421. Static methods use wrong JNI call function ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/jni-util.h@219 PS1, Line 219: Non-st > How about an even simpler one? I can make static methods JniCall::static(jc did this. Also started working on a fancier template variety that verifies argument types match the java method signature, etc, but will do that in some later patch http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/jni-util.h@227 PS1, Line 227: static JniCall static_method(jclass clazz, jmethodID method) WARN_UNUSED_RESULT { > WARN_UNUSED_RESULT could be added here and in other "fluent" functions. Done http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/jni-util.h@234 PS1, Line 234: > The same thing is checked twice here. Done http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/jni-util.h@410 PS1, Line 410: return JniCall::instance_method(obj, method).with_thrift_arg(arg).Call(); > line too long (103 > 90) Done http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/logging-support.cc File be/src/util/logging-support.cc: http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/logging-support.cc@139 PS1, Line 139: } > As this is already modified the RETURN_IF_ERROR could be replaced with simp Done http://gerrit.cloudera.org:8080/#/c/11181/1/be/src/util/logging-support.cc@144 PS1, Line 144: > Same as line 139. Done -- To view, visit http://gerrit.cloudera.org:8080/11181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6 Gerrit-Change-Number: 11181 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Aug 2018 22:06:12 +0000 Gerrit-HasComments: Yes
