Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 )
Change subject: IMPALA-7421. Static methods use wrong JNI call function ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11181/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11181/2//COMMIT_MSG@12 PS2, Line 12: -Xcheck:jni Wondering if we should enable it in the DEBUG build by default. http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/service/frontend.cc@229 PS2, Line 229: if (!err.empty()) { : return Status(err); single line. http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@250 PS2, Line 250: env_(getJNIEnv()) { I recently saw an Impalad crash because getJNIEnv() returned a nullptr and it was dereferenced. The issue turned out to be an OOM on the JVM and looks like a getJNIEnv() after that could return a NULL ptr. We should probably have non-debug assert for it. http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@273 PS2, Line 273: ObjectToResult WARN_UNUSED_RESULT for these... http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@451 PS2, Line 451: || Make it more strict with ^? http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@472 PS2, Line 472: jstring jstr = static_cast<jstring>(obj); : const char *str = env_->GetStringUTFChars(jstr, &is_copy); : RETURN_ERROR_IF_EXC(env_); : *result = str; : env_->ReleaseStringUTFChars(jstr, str); : RETURN_ERROR_IF_EXC(env_); Use JniUtfCharGuard? -- To view, visit http://gerrit.cloudera.org:8080/11181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6 Gerrit-Change-Number: 11181 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 11 Aug 2018 01:27:12 +0000 Gerrit-HasComments: Yes
