Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 )
Change subject: IMPALA-7421. Static methods use wrong JNI call function ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@250 PS2, Line 250: env_(getJNIEnv()) { > Should we fix that separately? It seems like there are 39 calls to getJNIEn FWIW, Joe tried to separate us from libhdfs's stuff but ran into bugs. https://issues.apache.org/jira/browse/HDFS-12628 has a reproduction and everything. -- To view, visit http://gerrit.cloudera.org:8080/11181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6 Gerrit-Change-Number: 11181 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 16:38:00 +0000 Gerrit-HasComments: Yes
