Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 )
Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql ...................................................................... Patch Set 1: Code-Review+1 (2 comments) 1 optional comment + 1 type, lgtm otherwise. http://gerrit.cloudera.org:8080/#/c/11201/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11201/1//COMMIT_MSG@10 PS1, Line 10: substracting the total time with the query : execution time since the test focuses type: subtract + I think that "subtracting the query execution time from the total time" would be better here. http://gerrit.cloudera.org:8080/#/c/11201/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11201/1/tests/shell/test_shell_commandline.py@707 PS1, Line 707: # In this test, we are only interested in the performance of Impala shell and not : # the performance of Impala query. So, we need to substract the total time with the : # query execution time. A potential way to make this simpler: wouldn't it also work to do an invalid query instead e.g. removing the "create" part so that the select will refer a non-existent table? -- To view, visit http://gerrit.cloudera.org:8080/11201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic87891f34872da65aac5ce02caf01da1c050efa5 Gerrit-Change-Number: 11201 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 11:51:00 +0000 Gerrit-HasComments: Yes
