Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 )
Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Carry Csaba's +1 http://gerrit.cloudera.org:8080/#/c/11201/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11201/1//COMMIT_MSG@10 PS1, Line 10: istent table instead since the test focuses : on Impala shell performance and not I > type: subtract + I think that "subtracting the query Done http://gerrit.cloudera.org:8080/#/c/11201/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11201/1/tests/shell/test_shell_commandline.py@707 PS1, Line 707: : def test_default_timezone(self): : """Test that the default > A potential way to make this simpler: wouldn't it also work to do an invali I like your suggestion. Since I no longer need the output, I can actually make pass -q in impala-shell to make the test even faster. I'll update the code. -- To view, visit http://gerrit.cloudera.org:8080/11201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic87891f34872da65aac5ce02caf01da1c050efa5 Gerrit-Change-Number: 11201 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 16:31:25 +0000 Gerrit-HasComments: Yes
