Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 )
Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11201/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11201/2/tests/shell/test_shell_commandline.py@688 PS2, Line 688: os.write(sql_file, "col_{0} as b{1},\n".format(i, i)) : os.write(sql_file, "col_{0} as c{1}{2}\n".format( : i, i, "," if i < num_cols - 1 else "")) : os.write(sql_file, "from non_existence_large_ta > With the rewrite, the test now finishes in 1 second or less :) I don't thin Done -- To view, visit http://gerrit.cloudera.org:8080/11201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic87891f34872da65aac5ce02caf01da1c050efa5 Gerrit-Change-Number: 11201 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 16:51:47 +0000 Gerrit-HasComments: Yes
