Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 )
Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql ...................................................................... Patch Set 4: (1 comment) See comment, would be +2 otherwise. http://gerrit.cloudera.org:8080/#/c/11201/4/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11201/4/tests/shell/test_shell_commandline.py@682 PS4, Line 682: sql_file, sql_path = tempfile.mkstemp() The file will not be deleted if you use mkstemp, see https://docs.python.org/2/library/tempfile.html Please use NamedTemporaryFile to ensure that the file is cleaned up. -- To view, visit http://gerrit.cloudera.org:8080/11201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic87891f34872da65aac5ce02caf01da1c050efa5 Gerrit-Change-Number: 11201 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 18:46:11 +0000 Gerrit-HasComments: Yes
