Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11225 )

Change subject: tests: ensure consistent logging format across tests
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Than you for doing this.

http://gerrit.cloudera.org:8080/#/c/11225/1/tests/conftest.py
File tests/conftest.py:

http://gerrit.cloudera.org:8080/#/c/11225/1/tests/conftest.py@56
PS1, Line 56:   logging.basicConfig(level=logging.INFO, format='-- 
%(threadName)s: %(message)s')
> Should we put a timestamp in here? We have a variety of these that do have
+1 for a timestamp



--
To view, visit http://gerrit.cloudera.org:8080/11225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55ef0214b43f87da2d71804913ba4caa964f789f
Gerrit-Change-Number: 11225
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:53:42 +0000
Gerrit-HasComments: Yes

Reply via email to