Hello Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11225
to look at the new patch set (#2).
Change subject: tests: ensure consistent logging format across tests
......................................................................
tests: ensure consistent logging format across tests
Many of the test modules included calls to 'logging.basicConfig' at
global scope in their implementation. This meant that by just importing
one of these files, other tests would inherit their logging format. This
is typically a bad idea in Python -- modules should not have side
effects like this on import.
The format was additionally inconsistent. In some cases we had a "--"
prepended to the format, and in others we didn't. The "--" is very
useful since it lets developers copy-paste query-test output back into
the shell to reproduce an issue.
This patch fixes the above by centralizing the logging configuration in
a pytest hook that runs prior to all pytests. A few other non-pytest
related tools now configure logging in their "main" code which is only
triggered when the module is executed directly.
I tested that, with this change, logs still show up properly in the .xml
output files from 'run-tests.py' as well as when running tests manually
from impala-py.test
Change-Id: I55ef0214b43f87da2d71804913ba4caa964f789f
---
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
M tests/conftest.py
M tests/metadata/test_hms_integration.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/scheduler.py
M tests/performance/workload_runner.py
M tests/run-tests.py
M tests/util/plugin_runner.py
12 files changed, 16 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/11225/2
--
To view, visit http://gerrit.cloudera.org:8080/11225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I55ef0214b43f87da2d71804913ba4caa964f789f
Gerrit-Change-Number: 11225
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
